Merged
Conversation
phiwuu
approved these changes
Feb 6, 2026
Member
phiwuu
left a comment
phiwuu
left a comment
There was a problem hiding this comment.
Thank you for fixing this! There are already a few system tests which verify checks. For example tests-system/checks-1 illustrates the correctness of your fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal change correcting the first example for Checks in the LRM.
As explained in Chapter 9 of the LRM, checks trigger if the expression evaluates to false.
This means the first example given would actually output a warning for every Requirement with a description of 10 chars or more!
Only requirements with short descriptions would pass this check.
This issue can be reproduced trivially with a minimal example, so no reproduction is provided here.