bazel: Split existing rules into reusable sub-rules#540
Merged
Conversation
castler
force-pushed
the
js_enable_reusable_subrules
branch
15 times, most recently
from
36d925c to
1e07d55
Compare
phiwuu
approved these changes
Feb 24, 2026
In order to to better structure the lobster.bzl, we split it into multiple parts. First thing is the provider in a custom bzl file. To not break the API, we re-export the symbol.
In order to to better structure the lobster.bzl, we split it into multiple parts. To not break the API, we re-export the symbol.
In order to to better structure the lobster.bzl, we split it into multiple parts. To not break the API, we re-export the symbol.
In order to to better structure the lobster.bzl, we split it into multiple parts. To not break the API, we re-export the symbol.
In order to to better structure the lobster.bzl, we split it into multiple parts. To not break the API, we re-export the symbol.
In some cases it migth be more helpfull, to use lobster_* as subrule, which is why we expose already one for our customers.
In some cases it migth be more helpfull, to use lobster_* as subrule, which is why we expose already one for our customers.
In some cases it migth be more helpfull, to use lobster_* as subrule, which is why we expose already one for our customers.
In a previous change we introduced a top-level directory called `bazel`. Which lead to the CI failing with the statement "permission denied". After quite some debugging, we were able to identify that the problem is, that this make-statement, would now try to execute the directory `bazel` - where it has no permisson - and not the binary within PATH. With this change, it is ensured, that `bazel` is interpreted as command.
phiwuu
force-pushed
the
js_enable_reusable_subrules
branch
from
1e07d55 to
f8f3536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.