Repository navigation
Conversation
|
@coderabbitai review |
[Low impact] The PR appears safe to merge. Summary
Reviews (1) · Last reviewed commit: "feat(build): run plan verification comma..." · Reviewed by Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Nice addition. One suggestion for the This stays within the PR's design. Investigation still does not ask the human, and the halt applies to oneshot too, since oneshot skips the Open Questions checkpoint. The criteria come from Matt Pocock's |
|
Thanks @rubensousa-uw, good catch. A test that fails for a nearby reason, or a flaky one, would have satisfied the old wording. Taken as suggested, with Credit to Matt Pocock's |
What
bmad-buildnow reproduces a bug before fixing it, and runs the plan's## Verificationcommands itself before review.Why
bmad-ticketalready requires a test that fails on the defect and passes on the fix;bmad-builddid not.How
step-02-plan.md: for a bug fix, put the failing test or command in## Verification.step-03-implement.md: new Run Verification step before the Matrix Test Audit.step-oneshot.md: run the same commands before review.Testing
uv run tools/validate_skills.py --strictuv run tools/validate_file_refs.py --strictuv run --frozen python -B -m pytest