Skip to content

Conversation

@denisacostaq
Copy link

flex project has been moved to github:
http://flex.sourceforge.net/

@purpleidea
Copy link
Collaborator

@denisacostaq If you're going to change the link, ok, but you should reflow to 80 chars.

@denisacostaq
Copy link
Author

@denisacostaq If you're going to change the link, ok, but you should reflow to 80 chars.

thankyiu @purpleidea solved in 6fcf2d6

@purpleidea
Copy link
Collaborator

@denisacostaq Sorry I should have mentioned it earlier, but the convention is to not break links across lines, so you'll need to fix that, and you can rebase all your commits into a single one and force push.

@purpleidea
Copy link
Collaborator

Still not correct, the link is broken, and you want only ONE commit at the end please.

@denisacostaq
Copy link
Author

@purpleidea is right now?

@purpleidea
Copy link
Collaborator

Almost:

The link should be:

[Foo does not break](URL)

IIRC

Foo

@purpleidea
Copy link
Collaborator

bbl

@denisacostaq
Copy link
Author

Almost:

The link should be:

[Foo does not break](URL)

IIRC

Foo

@purpleidea the example you shared me [text](url) is how GitHub Flavored Markdown Spec recommend, but if you look in the org REAME you can find this for example:

== Toy Pascal ==

The Flex manual also exhibits a http://flex.sourceforge.net/manual/Simple-Examples.html[scanner for a toy Pascal-like language],
though last I checked, its comment regex was a little buggy. Here is a

and I want to be consitent with this, I think the [] can be breake in multplie lines because it is not the link at all, but if you prefer this way you can fix this, including to fix the new link I am pointing in the pr and close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants