WebSocket Library #4348
Open
WebSocket Library #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieusieben
approved these changes
Nov 17, 2025
Contributor
matthieusieben
left a comment
matthieusieben
left a comment
There was a problem hiding this comment.
Quite straight forward, looks good! I would maybe recommend using a less generic name (@atproto/websocket, from the name alone, could appear to be a client and/or server thing)
| @@ -0,0 +1,35 @@ | |||
| { | |||
| "name": "@atproto/websocket", | |||
Contributor
There was a problem hiding this comment.
nit: would call this something more specific like websocket-server or keepalive-ws-server
| @@ -0,0 +1,35 @@ | |||
| { | |||
| "name": "@atproto/websocket", | |||
| "version": "0.0.1", | |||
Contributor
There was a problem hiding this comment.
I might be wrong but I think that even new packages need a changeset to be released by our ci.
Contributor
There was a problem hiding this comment.
(i think you have to create them manually as pnpm changeset won't pickup on new packages)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls the
WebSocketKeepAlivecode out ofxrpc-serverinto its own package so that we can re-use it in #4290Arguably this package should contain utilities for working with XRPC subscriptions, but I decided to hold off on moving that code over as we're actively working on refactoring lexicon/xrpc stuff more generally