src: signing: Add zero-copy verification and ACCEPT_UNKNOWN_MSGID - #12
Draft
joaoantoniocardoso wants to merge 4 commits into
Conversation
Add an opt-in const generic (default off) that forwards frames whose message id is absent from the compiled dialect instead of dropping them. The is_known_msgid check runs only on the CRC-failure path, so the hot path is unaffected; forwarded unknown frames are CRC-unvalidated by definition. Wire it through the mavlink_codec! macro and cover both router-forward and strict-drop behavior with tests.
Used by the in-crate MAVLink2 signature verification.
Add link id, timestamp (raw and u64), and value accessors with their size constants, following the existing field-accessor style and tests.
Reimplement MAVLink2 signing verification in-crate over the borrowed frame bytes, avoiding the copy into rust-mavlink's MAVLinkV2MessageRaw. The codec verifies through Decoder::decode(&mut self), so the per-stream replay state is mutated through exclusive access and needs no Mutex.
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #11.