lib: drivers: serial: Fix Windows COM parse - #228
Merged
joaoantoniocardoso merged 2 commits intoAug 24, 2026
Merged
Conversation
Member
|
Nice, I cannot test, but the code looks sane. The commits need to be cleaned up: there are multiple commits touching the same lines. |
serialport prepends \\.\ unless the path already starts with \, so /COM3 fails to open. Parse host or strip the slash on COM ports, and accept baud from the URL port. Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
patrickelectric
force-pushed
the
fix-windows-serial-com
branch
from
August 24, 2026 11:28
9d0e2a2 to
7e458aa
Compare
Member
Author
|
done, squashed to fix + tests |
joaoantoniocardoso
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legacy serial:COM3:57600 stores the port as the URL host and the baud as the URL port, so path is empty.
Fix #211