Skip to content

Tie vehicles to joystick profiles - #857

Merged
patrickelectric merged 3 commits into
bluerobotics:masterfrom
rafaellehmkuhl:tie-vehicles-to-joystick-profiles
Apr 10, 2024
Merged

Tie vehicles to joystick profiles#857
patrickelectric merged 3 commits into
bluerobotics:masterfrom
rafaellehmkuhl:tie-vehicles-to-joystick-profiles

Conversation

@rafaellehmkuhl

@rafaellehmkuhl rafaellehmkuhl commented Apr 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • Allows assigning different vehicle types to a joystick mapping
  • Auto-set joystick mapping on boot based on vehicle type

Fix #858
Fix #859

@rafaellehmkuhl
rafaellehmkuhl force-pushed the tie-vehicles-to-joystick-profiles branch 2 times, most recently from 1ea208e to 5facd87 Compare April 4, 2024 21:37
@rafaellehmkuhl
rafaellehmkuhl marked this pull request as ready for review April 4, 2024 21:38
@rafaellehmkuhl
rafaellehmkuhl requested a review from a team April 4, 2024 21:38
@rafaellehmkuhl

rafaellehmkuhl commented Apr 8, 2024

Copy link
Copy Markdown
Member Author

@patrickelectric @ArturoManzoli could you take a look at this one to see if it's working properly? If so I will add it to a Beta14 release today.

patrickelectric
patrickelectric approved these changes Apr 8, 2024
View reviewed changes

@patrickelectric patrickelectric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be free to merge it

@rafaellehmkuhl

rafaellehmkuhl commented Apr 8, 2024

Copy link
Copy Markdown
Member Author

Be free to merge it

Have you tested it?

@patrickelectric

patrickelectric commented Apr 8, 2024

Copy link
Copy Markdown
Member

Be free to merge it

Have you tested it?

I'm in a meeting right now, can test it tomorrow. Codewise looks good.

patrickelectric
patrickelectric requested changes Apr 9, 2024
View reviewed changes

@patrickelectric patrickelectric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow all widgets are now missing and I can't open the configuration menu:

image

image

@rafaellehmkuhl
rafaellehmkuhl force-pushed the tie-vehicles-to-joystick-profiles branch from 5facd87 to 15b84d2 Compare April 9, 2024 20:01
@rafaellehmkuhl

rafaellehmkuhl commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

Somehow all widgets are now missing and I can't open the configuration menu

That's strange.
There's no change to any widget logic whatsoever, and I'm testing with @JoaoMario109 right now and everything went fine.

Are you sure you're on the right branch?

joaomariolago
joaomariolago approved these changes Apr 9, 2024
View reviewed changes

@joaomariolago joaomariolago left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and everything seems to be fine, only await @patrickelectric clarify about the bug that happened in prior comment.

patrickelectric
patrickelectric approved these changes Apr 10, 2024
View reviewed changes

@patrickelectric patrickelectric left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested in my laptop and it's working fine. Not sure what happened on my desktop though, will check tomorrow

@patrickelectric
patrickelectric merged commit b4689e4 into bluerobotics:master Apr 10, 2024
@rafaellehmkuhl
rafaellehmkuhl deleted the tie-vehicles-to-joystick-profiles branch April 10, 2024 12:11
@goasChris goasChris mentioned this pull request Apr 30, 2024
Merged
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jul 8, 2024
@ES-Alexander ES-Alexander mentioned this pull request Jan 6, 2025
Merged
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 6, 2025
@ES-Alexander ES-Alexander added docs-minimal See docs PR for suggested improvements and removed docs-needed Change needs to be documented docs-in-progress Included in an open docs PR labels Jan 15, 2025
@ES-Alexander ES-Alexander mentioned this pull request Jul 10, 2025
Merged
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jul 10, 2025
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-in-progress Included in an open docs PR docs-minimal See docs PR for suggested improvements labels Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes
@joaomariolago joaomariolago joaomariolago approved these changes

Assignees

No one assigned

Labels

docs-complete Change documentation has been completed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auto-change the joystick profile based on vehicle type Allow making a joystick mapping the default one for a vehicle type

4 participants

@rafaellehmkuhl @patrickelectric @joaomariolago @ES-Alexander