fix: open external links in the OS browser on Standalone#2816
Conversation
Electron opened http(s) links in a new BrowserWindow instead of the user's default browser. Route external links through shell.openExternal via setWindowOpenHandler and will-navigate, keeping in-app navigation inside Cockpit.
Automated PR Review (Claude)0. SummaryVerdict: READY TO MERGE This single-commit PR fixes external links (http/https/mailto) in the Electron (Standalone) build so they open in the OS default browser instead of spawning a new 1. Correctness & Implementation Bugs — ✅2. AGENTS.md Adherence — ✅3. Security — ✅4. Performance — ✅5. UI / UX — ✅6. Code Quality & Style — ✅7. Commit Hygiene — ✅8. Tests — ✅9. Documentation — ✅10. Nitpicks / Optional10.1 nit — Generated by Claude. This is advisory; a human reviewer must still approve. |
Will ignore the nit. |
Opens external links in the OS preferred browser instead of in an Electron window.
To test it, just open
/menu/aboutand click the links there.Fixes #2612