Skip to content

Update Electron to the latest version - #2220

Closed
rafaellehmkuhl wants to merge 3 commits into
bluerobotics:masterfrom
rafaellehmkuhl:update-electron
Closed

Update Electron to the latest version#2220
rafaellehmkuhl wants to merge 3 commits into
bluerobotics:masterfrom
rafaellehmkuhl:update-electron

Conversation

@rafaellehmkuhl

Copy link
Copy Markdown
Member

An update released during October is believed to increase the performance on macOS significantly (with a strong support other devs, based on the reactions to the mentioned PR).

I also investigated the bug we had last time around blank screens on Windows, and I believe to have fixed it in the 3rd commit (router: Fix reversed history mode).

Needs some extra testing on Windows to make sure there are indeed no new bugs.

Maybe to be merged only after the 1.17.0 stable release.

@ES-Alexander ES-Alexander left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some basic testing (widgets, joystick, video, map, telemetry) on an M4 Macbook Air, and it seemed to work fine.

Would be good if it can be tested with other OSs before merging, and possibly with greater depth of features (especially that Electron might be involved in, like serial connections).

The recommended approach is to use Hash Mode on Electron and History Mode on web. We had the opposite.
@rafaellehmkuhl
rafaellehmkuhl marked this pull request as draft November 18, 2025 21:11
@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

Putting as draft as in the built version it's opening by default in the mission planning view, and this view is not being rendered.

Let's wait and put that in the 1.18 cycle to make things easier.

@ES-Alexander

Copy link
Copy Markdown
Contributor

Reminder of this, since 1.17 is released now.

Not sure if this automatically updates electron-updater and electron-builder as well, but if it does then we could potentially make use of Apple’s new icon functionality too, thanks to this change :-)

@rafaellehmkuhl

Copy link
Copy Markdown
Member Author

Closing in favor of #2672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants