src: mavlink: camera: Add camera discovery and selective recording - #34
Open
joaoantoniocardoso wants to merge 3 commits into
Open
src: mavlink: camera: Add camera discovery and selective recording#34joaoantoniocardoso wants to merge 3 commits into
joaoantoniocardoso wants to merge 3 commits into
Conversation
joaoantoniocardoso
force-pushed
the
camera_discovery_recording
branch
6 times, most recently
from
July 15, 2026 22:57
37ec04e to
8f853e8
Compare
joaoantoniocardoso
marked this pull request as ready for review
July 16, 2026 02:53
patrickelectric
left a comment
patrickelectric
left a comment
Member
There was a problem hiding this comment.
can you rebase this over master ?
joaoantoniocardoso
force-pushed
the
camera_discovery_recording
branch
from
July 17, 2026 17:08
8f853e8 to
3863aad
Compare
patrickelectric
requested changes
Jul 20, 2026
Wire the camera discovery module into the mavlink handler: register cameras from heartbeats, request CAMERA_INFORMATION, and track which cameras report a recording capability. The service owns the CameraDiscoverer and the recording-capable set, keyed by system and component id.
Handle VIDEO_STREAM_INFORMATION to register a video stream per camera and COMMAND_LONG to toggle its recording state. The service gates recording of video/ topics on whether the corresponding stream has been requested, so only explicitly requested streams are written.
joaoantoniocardoso
force-pushed
the
camera_discovery_recording
branch
from
July 20, 2026 21:36
3863aad to
0ee9215
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge after #33
Adds the camera discovery feature