Skip to content

Improve caching - #76

Merged
patrickelectric merged 2 commits into
bluerobotics:masterfrom
joaoantoniocardoso:improve_caching
Jun 23, 2026
Merged

Improve caching#76
patrickelectric merged 2 commits into
bluerobotics:masterfrom
joaoantoniocardoso:improve_caching

Conversation

@joaoantoniocardoso

Copy link
Copy Markdown
Member

btw, the cleanup_caches was not actually deleting caches because it lacked write permissions, and the caches were rarely there, so we don't actually need it.

Store build layers in GitHub Actions cache instead of DockerHub or
BuildKit GHA backend. Cache keys are shared across branches when inputs
match, and the existing 6-day schedule keeps entries warm.
Build cache now lives in actions/cache, so this workflow no longer
applies. It also failed on every run (missing actions:write) and would
delete PR-scoped caches on merge.
@patrickelectric

Copy link
Copy Markdown
Member

did you test this ?

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

I'll send a ghost commit to test the caching.

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

@patrickelectric it looks like it is working.

@patrickelectric

Copy link
Copy Markdown
Member

please, delete the commit for us to merge

@joaoantoniocardoso

Copy link
Copy Markdown
Member Author

@patrickelectric done

@patrickelectric
patrickelectric merged commit 51ac275 into bluerobotics:master Jun 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants