Open
Conversation
GuyL99
requested changes
Feb 13, 2023
Cargo.toml
Outdated
| serde = { version = "^1.0", features = ["derive"] } | ||
| serde_json = "^1.0" | ||
| cherrybomb-engine = "^0.1" | ||
| cherrybomb-engine = {path = "cherrybomb-engine"} |
| } | ||
|
|
||
| impl<T: OAS + Serialize> ActiveScan<T> { | ||
| pub async fn check_ssl(&self, auth: &Authorization, serv: &Vec<Server>) -> CheckRetVal { |
Contributor
There was a problem hiding this comment.
This is not in the description of the pull, this is a new check
| for (k, v) in vars { | ||
| new_server_addr = | ||
| new_server_addr.replace(&format!("{{{k}}}"), v.default.as_str()); | ||
| pub fn servers( |
| @@ -93,109 +94,108 @@ impl_passive_checks![ | |||
| ]; | |||
|
|
|||
| impl_active_checks
DeliciousBounty
force-pushed
the
server_override
branch
from
a4cd039 to
9deee90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#119
Hey @GuyL99 ,
I resolved the server override in accordance with the opened issue.
Simply put, the "server override" property from the configuration file overrides every server in the OAS file. Secondly, the "—server" flag from the command line will override the configuration file's server.
In macro.rs.req.rs, I changed few things.
I did not make changes to all of the other tests; at this time, just one check has changes, and the rest are commented.