Jason.Holloway User-Interface-Project-Week by jjamaltwin · Pull Request #574 · bloominstituteoftechnology/User-Interface-Project-Week

jjamaltwin · 2018-12-31T16:39:13Z

@VivaCode

…fect later

… mobile media query

…ices page

…u header and opacity

…100vh

… fixed the size

VivaCode

Functional Components - II

MVP

Build layout HTML/LESS: Home page desktop design
Build layout HTML/LESS: Home page mobile design
Build layout HTML/LESS: Services page desktop design only
Build layout HTML/LESS/JavaScript: Navigation system design (expanded and non)
Build Custom Component HTML/LESS/JavaScript: Services page tab navigator design

What Looks Great

Great work matching the design files
Frequent and descriptive commits
Code easy to read

What Could Be Improved

Code needs better formatting - you should only use id in case of emergency. Overuse could mean that you have a weak understanding of how to style.
Descriptive class names
Add more comments so code is easier for other programmers as well as yourself

What Could Be Added

More Comments esp in the js so anyone can tell what each chunk of code should do
Separate js pages for each component.

Rating (1-3)

2

VivaCode · 2019-01-11T00:33:56Z

contact.html

 </head>

 <body>
+	<div class="container12">


I can see how container number might initially work, but what happens when you get to container100 and you can't remember what each of them control. Container should be reserved for the main wrapper only and the other receive descriptive names eg: container19 = menu_container

VivaCode · 2019-01-11T00:34:33Z

contact.html

+
+								</div>
+
+								<div class="container21">


great job with the radio buttons!

VivaCode · 2019-01-11T00:46:33Z

index.html

+							 </ul>
+							</div>
+						</header>
+						<img id="pic1" src="img\home\home-jumbotron.png" alt="jumbo" style="width:100%">


neither of these should have a width. I think I told you about it twice but maybe you missed looking inline

VivaCode · 2019-01-11T00:47:36Z

index.html

+					<div class="container2">
+
+					<div class ="picwrapper">
+						<img id="pic1" class="notepad" src="img\home\home-img-1.png" alt="penandpad">


Why did these need an id? nothing on this project should require that specific weight

VivaCode · 2019-01-11T00:53:53Z

index.html


-Enter email
+
+				</civ>


? This is what clean code helps prevent. This could have caused bugs.

VivaCode · 2019-01-11T00:56:19Z

index.html

+
+				<h6>copyright © 2018 Smith and Jones </h6>
+
+			</div>


This doesn't need two containers. class copyright would have been sufficient.

VivaCode · 2019-01-11T00:56:53Z

js/index.js

+
+}
+
+// SERVICES TABS


great job using comments

VivaCode · 2019-01-11T00:58:20Z

js/index.js

@@ -1 +1,64 @@
-// JS goes here
+


I would advise for future projects to use a separate js file for each feature. Just for readability, reusability and ease of debugging

VivaCode · 2019-01-11T01:00:17Z

services.html

+								<img src="img\services\services-tab-sustainability-img.png" alt="construction" style="width:100%">

-	<h1>Services</h1>
+							</div>


good job pulling from old code!

VivaCode · 2019-01-11T01:01:37Z

services.html

+
+				</div>
+
+				<div class="container16">


don't forget to reuse components like nav and footer that match across pages. this saves time and creates cleaner code as well as pages that match.

jjamaltwin added 30 commits December 31, 2018 10:37

first push, working on header for Home page

714fbdd

working on header image, nav-bar button and header

de49013

working on drop-down nav button

7b34bfd

working on image text positioning

5499b66

finally got text in place, moving on to main content

d9687fd

trying to place image and paragrah in proper postion

5072032

tweaking the aligment of text and image

944de34

finished first paragraph , button , and image, will make it pixel per…

faa032a

…fect later

working on middle content alignment

40e559b

fixed the top paragrah alignment

928717a

added villas photo and third header

26d4f9f

moving on to next image and content

1b9724e

centered villasp

e334ed4

set outskirts image in place with image text

0c8a174

finished outskirts content

744eeeb

finished the blocks content and image

30397f5

working on footer

dc982c1

working on footer

9c7917a

finished second state info for footer

87ab652

finishing footer

23e1bcd

working on footer

561d477

working on image sub headers using relative and absolute on divs

e3bf76e

finished subheaders, now moving on to mobile design

621a472

working on mobile design

bbfb623

started designs from scratch, making final adjustments and working on…

54d374d

… mobile media query

working on mobile design

cd1f23c

halfway done with mobile design

6257f37

working on navigation button and functionality

6f83dcc

got functionality working for home nav menu, now working on design

8f02aea

finished expanded view of nav bar, moving on to tab funtion for serv…

c118a65

…ices page

jjamaltwin added 29 commits January 8, 2019 14:15

added opacity to nav menu open design

6c16b73

fixed the header's responsive design

3ba6acd

tweaking the header nav button

9bc5179

working on villa subheader position

8b07a12

finally got villas subheader on pic in position for mobile design

11e9f3b

finishing mobile design, spacing, margin, and working on dropdown men…

3301c78

…u header and opacity

making final adjustments

c8dc317

trying to adjust size of menu close image.

2db3131

fixed nav close button

ab41e88

working on nav menu background color

fc417f0

working on services header and services menu header

402c48b

working on sevices menu close image/button

89bf7f1

final push

5369152

fixed villas paragraph

561c90e

working on opacity for nav menu

1e3aaeb

set the vh to 100

a43bbe1

working on services menu

402781e

fixed services opacity and positioning, menu covers full screen with …

90b2512

…100vh

cleaning up index.less and labeling design segments

b4dcdc7

fixed the spacing on services page between image and paragraph, also…

f6c1fcb

… fixed the size

fixed villasp on home page

ab71920

fixed foooter spacing on home page

d94d1ea

working on header on contact page

b3e553b

placed <p> contact us on image properly

8bad7ce

working on content for contact page

11ba25c

working on second form, contact page

fbebe91

working on select form , contact page

fa19d4b

figured out number select form, contact page

b7114b1

final push before project form

10e1f7e

VivaCode reviewed Jan 11, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jason.Holloway User-Interface-Project-Week#574

Jason.Holloway User-Interface-Project-Week#574
jjamaltwin wants to merge 83 commits intobloominstituteoftechnology:masterfrom
jjamaltwin:master

jjamaltwin commented Dec 31, 2018

Uh oh!

VivaCode left a comment

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

VivaCode Jan 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jjamaltwin commented Dec 31, 2018

Uh oh!

VivaCode left a comment

Choose a reason for hiding this comment

MVP

What Looks Great

What Could Be Improved

What Could Be Added

Rating (1-3)

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants