fix: credit order parsing #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all responses are loaded as symbols (see JSON parsing in http.rb). Thus all map accesses through strings are currently failing. This fixes the parsing methods to support symbols and correctly handle API responses. This also adds a return value to the POST order call, returning the order_id, necessary to use during the fetch of the credit order data. note: the public method get_decision is currently not working though it is not in the path of a simple integration to the API, it should be fixed next.
currently emails are sent as a single object, the API is expecting an array of emails
currently the credit order payload is sending extraneous parameters in body. Those are not expected nor handled by the API
Contributor
Author
jiahou
requested changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all responses are loaded as symbols (see JSON parsing in http.rb). Thus all map accesses through strings are currently failing.
This fixes the parsing methods to support symbols and correctly handle API responses. This also adds a return value to the POST order call, returning the order_id, necessary to use during the fetch of the credit order data.
note: the public method get_decision is currently not working though it is not in the path of a simple integration to the API, it should be fixed next.