-
Notifications
You must be signed in to change notification settings - Fork 231
Net #5589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Net #5589
Conversation
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
analyze
sc_parallel_logicalsc_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
nogensc [setup failure]
sc_drop [core dumped]
logfill_logput_window_generated
incoherent_slow
timepart_retention1
simple_timepart
sc_timepart
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
0a5734f to
a0623a9
Compare
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
This keeps appsock thread available for work, while main-thd prepares hostinfo required for a dbinfo response. Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Although, this was never expensive (there were only 2 options: 'replicantion', and 'offloadsql'), this eliminates lookup entirely for most uses. Signed-off-by: Akshat Sikarwar <[email protected]>
This simplifies pausing accepts when connection throttling is needed. Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Create eventbase when connection runs a query. Cache created eventbase to be reused by subsequent connections. Each eventbase creates a socketpair and increses file-descriptor use when server accepts very large number of connections. This will limit fd use by limiting number of eventbases created (#sql-thds + #max-sql-queue) Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
roborivers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
maxtable [setup core dumped]
catchup_idle [setup core dumped]
rebuild_table_options [setup core dumped]
sirace [setup core dumped]
cinsert_linearizable [setup core dumped]
truncatesc [setup core dumped]
systable_locking [setup core dumped]
verify_writes [setup core dumped]
sc_force [setup core dumped]
socksql_master_swings [setup core dumped]
/silent