Skip to content

Conversation

@akshatsikarwar
Copy link
Contributor

/silent

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
analyze
sc_parallel_logicalsc_generated
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
nogensc [setup failure]
sc_drop [core dumped]
logfill_logput_window_generated
incoherent_slow
timepart_retention1
simple_timepart
sc_timepart
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated

Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
This keeps appsock thread available for work, while main-thd prepares
hostinfo required for a dbinfo response.

Signed-off-by: Akshat Sikarwar <[email protected]>
Although, this was never expensive (there were only 2 options:
'replicantion', and 'offloadsql'), this eliminates lookup entirely for
most uses.

Signed-off-by: Akshat Sikarwar <[email protected]>
This simplifies pausing accepts when connection throttling is needed.

Signed-off-by: Akshat Sikarwar <[email protected]>
Create eventbase when connection runs a query. Cache created eventbase
to be reused by subsequent connections.

Each eventbase creates a socketpair and increses file-descriptor use
when server accepts very large number of connections. This will limit fd
use by limiting number of eventbases created (#sql-thds + #max-sql-queue)

Signed-off-by: Akshat Sikarwar <[email protected]>
Signed-off-by: Akshat Sikarwar <[email protected]>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
maxtable [setup core dumped]
catchup_idle [setup core dumped]
rebuild_table_options [setup core dumped]
sirace [setup core dumped]
cinsert_linearizable [setup core dumped]
truncatesc [setup core dumped]
systable_locking [setup core dumped]
verify_writes [setup core dumped]
sc_force [setup core dumped]
socksql_master_swings [setup core dumped]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants