Skip to content

Set catchup-window to 0 #5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set catchup-window to 0 #5570

wants to merge 1 commit into from
+8 −0

Conversation

@markhannum
Copy link
Contributor

@markhannum markhannum commented Nov 13, 2025 •
edited
Loading

Fix incoherent_startup test.

roborivers
roborivers suggested changes Nov 13, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 12/42 tests failed ⚠.

@markhannum markhannum force-pushed the fix_incoherent_startup branch 2 times, most recently from 8c8c8bd to 6ed51b7 Compare November 13, 2025 19:33
roborivers
roborivers approved these changes Nov 13, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

@markhannum markhannum force-pushed the fix_incoherent_startup branch 2 times, most recently from 7cc7e5b to 1b6850d Compare November 17, 2025 21:07
roborivers
roborivers suggested changes Nov 18, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/633 tests failed ⚠.

The first 10 failing tests are:
logfill_logput_window_generated
consumer_non_atomic_default_consumer_generated
sc_downgrade
insert_lots
reco-ddlk-sql

@markhannum markhannum force-pushed the fix_incoherent_startup branch from 1b6850d to 09d5a06 Compare November 19, 2025 19:49
@markhannum markhannum force-pushed the fix_incoherent_startup branch from 09d5a06 to 4596957 Compare November 19, 2025 20:24
roborivers
roborivers suggested changes Nov 20, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/634 tests failed ⚠.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
commit_lsn_map
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@roborivers roborivers roborivers requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markhannum @roborivers