{181155186} stored procedure's cstring performance #5528
Conversation
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
timepart_auth [setup failure]
newsqlreplay
random_osql_replay
sc_lotsoftables
dohsql_race
sc_drop
pg_free_recovery
insert_lots
insert_lots_ssl_generated
updcolsbug
rishitha957
force-pushed
the
sp-cstr-perf
branch
from
f2c9ba9 to
d5cd244
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
rishitha957
force-pushed
the
sp-cstr-perf
branch
from
d5cd244 to
1d82f7a
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.
The first 10 failing tests are:
sc_truncate_lockorder_generated
triggersc_latency
sp_perf
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
rishitha957
force-pushed
the
sp-cstr-perf
branch
2 times, most recently
from
f9f4065 to
30732f4
Compare
|
/adhoc-test commit_lsn_map |
Signed-off-by: Rishitha Kalicheti <[email protected]>
rishitha957
force-pushed
the
sp-cstr-perf
branch
from
30732f4 to
fe7dfff
Compare
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
3 participants
EN: currently lua functions like gmatch, gsub{str_gsub}, g_write(io_write, fwrite), len {str_len}, str_reverse, str_lower.. most of the strlib functions call strlen on cstring type making it expensive. (Also because lua strings are immutable, we can store len of the string for cstring as we push on to the lua's stack