-
Notifications
You must be signed in to change notification settings - Fork 9
Deprecate get_address_logs endpoint #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant REST_API
participant Helpers
Client->>REST_API: GET /v1/get_address_logs
REST_API->>Helpers: create_deprecation_response()
Helpers-->>REST_API: Deprecation ToolResponse (HTTP 410)
REST_API-->>Client: Deprecation notice response
Estimated code review effort2 (~15 minutes) Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates the get_address_logs
endpoint by removing it from the MCP tool interface while maintaining backward compatibility for REST API users. The change addresses LLM misuse patterns where this tool was preferred over the more efficient workflow of using get_transactions_by_address
followed by get_transaction_logs
.
- Removes
get_address_logs
from MCP server tool registration and manifests - Converts REST endpoint to return a static 410 deprecation notice with guidance
- Updates all documentation to reflect the deprecation and removal
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
blockscout_mcp_server/server.py | Removes get_address_logs import and tool registration |
blockscout_mcp_server/api/routes.py | Replaces endpoint logic with deprecation response |
blockscout_mcp_server/api/helpers.py | Adds helper function to generate standardized deprecation responses |
blockscout_mcp_server/tools/address_tools.py | Adds deprecation comment explaining reasoning |
tests/api/test_routes.py | Replaces functional tests with deprecation behavior verification |
dxt/manifest.json | Removes tool from DXT manifest |
Multiple documentation files | Updates to remove references and document deprecation |
Summary
get_address_logs
Closes #168
https://chatgpt.com/codex/tasks/task_b_687ec2ea40e88323b9185cfcd8d5689a
Summary by CodeRabbit
New Features
/v1/get_address_logs
endpoint, including guidance on alternative workflows.Documentation
get_address_logs
as deprecated and removed references to it across all docs and help pages.Chores
get_address_logs
from tool lists, manifests, server registration, and UI tool listings.