Skip to content

Reopening Token Metadata fix #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leo42 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reopening Token Metadata fix #410

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc70331
Support HexString metadata (not including '0x')
leo42 Sep 13, 2023
5f828ad
Update metadata.ts
leo42 Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 19 additions & 11 deletions src/functions/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,25 @@ export const getOnchainMetadata = (
onchainMetadataResult = foundMetadata;
isFound = true;
} else {
// Fallback
// Due to previously missing and then incorrect implementation, metadata submitted as v2
// (i.e. "version" field encoded in CBOR was set to 2) with mistakenly text-encoded
// policies/asset names (which is CIP25v1 method of encoding) instead of correct CIP25v2
// byte-encoded keys passed as valid. (Note that the version number is a user input
// independent of the actual metadata content).
// To prevent breaking change, in case we don't find metadata for an asset under
// correct byte-encoded key, we fallback to CIP25v1 text-encoded format.
onchainMetadataResult =
internalOnchainMetadata[policyId][assetNameVersion1] || null;
isFound = false;
const foundHexStringMetadata = foundAssetInCbor
? internalOnchainMetadata[policyId][assetNameBase]
: null;
if (foundHexStringMetadata) {
onchainMetadataResult = foundHexStringMetadata;
isFound = true;
}else{
// Fallback
// Due to previously missing and then incorrect implementation, metadata submitted as v2
// (i.e. "version" field encoded in CBOR was set to 2) with mistakenly text-encoded
// policies/asset names (which is CIP25v1 method of encoding) instead of correct CIP25v2
// byte-encoded keys passed as valid. (Note that the version number is a user input
// independent of the actual metadata content).
// To prevent breaking change, in case we don't find metadata for an asset under
// correct byte-encoded key, we fallback to CIP25v1 text-encoded format.
onchainMetadataResult =
internalOnchainMetadata[policyId][assetNameVersion1] || null;
isFound = false;
}
}
} catch (error) {
onchainMetadataResult = null;
Expand Down