feat: onboard PostgreSQL schemas with baseline verification - #1327
Open
aparajon wants to merge 4 commits into
Open
feat: onboard PostgreSQL schemas with baseline verification#1327aparajon wants to merge 4 commits into
aparajon wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated integration test reuses a fixed-deadline context after running onboarding, which can cause flaky Stop/Status failures due to context deadline exhaustion.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enables schemabot onboard to accept PostgreSQL databases through the existing import + verification workflow, so PostgreSQL can be onboarded into declarative schema files and then baseline-verified via a no-change plan (matching the MySQL/Vitess experience).
Changes:
- Allow PostgreSQL database type in
buildOnboardWritePlan(previously rejected). - Add a unit test to ensure PostgreSQL pull output (quoted identifiers + index statements) is written verbatim and the generated
schemabot.yamltype ispostgres. - Extend the local-runtime integration test to run
schemabot onboardand assert the default “verified baseline” behavior for both MySQL and PostgreSQL.
File summaries
| File | Description |
|---|---|
| pkg/cmd/commands/onboard.go | Permits postgres as a supported type for generating the onboarding write plan. |
| pkg/cmd/commands/onboard_test.go | Adds coverage for PostgreSQL onboarding write output (config + .sql contents). |
| integration/localruntime/supervisor_test.go | Exercises the CLI onboarding + baseline verification flow for both engines in local runtime. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aparajon
marked this pull request as ready for review
September 7, 2026 05:49
aparajon
requested review from
JashLal,
Kiran01bm,
eeSeeGee,
jayjanssen,
jemiahw and
morgo
as code owners
September 7, 2026 05:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
schemabot onboardrejects PostgreSQL after pulling its schema. This blocks the same verified import workflow that MySQL and Vitess already use.What
Allow PostgreSQL through the existing import path. Keep table DDL and indexes intact, write the engine into the schema configuration, and verify a no-change baseline by default.
How
The existing writer and plan verification handle PostgreSQL without a separate workflow. The local-runtime integration now exercises CLI onboarding against both MySQL and PostgreSQL.
Risk
Import writes local files and verifies a plan; it does not apply changes. Existing overwrite protection and verification failures still apply.
Bigger picture
Builds on #1326. This lets future interactive and agent-driven setup share the same verified import path for both engines.
Generated with Codex