refactor: render Spirit progress from structured fields, not a parsed string

[aparajon]

Why this matters

SchemaBot carried a regex that parsed a Spirit-shaped progress line (71436/221193 32.30% copyRows …) back into row counts and a percentage, and the engine wrapper went out of its way to produce such a line from Spirit's structured per-table counters so the CLI could parse it again. Every value that round trip recovered is already a typed field on status.Progress: the per-table rows, the checksum counters, the throttle status, and the ETA (status.ETA{State, Duration}), which the engine has consumed structurally for some time. The parser had also gone dead on the live path, since no server layer populates the wire field it read, so it only ever ran against preview fixtures — but a parser that mimics an engine's log format is exactly the kind of workaround AGENTS.md's Upstream First rule names, and docs/spirit_progress.md still told readers the ETA was regex-parsed out of Summary.

What it does

• Deletes ParseSpiritProgress, its regex, and the SpiritProgressInfo type from the CLI templates, along with both call sites: the override in ParseProgressResponse and the string-first branch of the in-progress table renderer. The renderer's structured branches (estimate-exceeded, bar, rows/ETA line, phase status) already covered every case the string branch did.
• Stops buildSpiritTableProgress from synthesizing a "%d/%d %d%% copyRows" detail string. engine.TableProgress.ProgressDetail remains a free-text note for a human — Spirit's Summary before per-table progress exists, or the direct-execution marker — and its comment now says so.
• Drops ProgressDetail from the CLI's internal templates.TableProgress; the public apitypes JSON field and the proto field are untouched.
• Rewrites the stale parts of docs/spirit_progress.md: the status.Progress table now lists ETA and Checksum, Summary is documented as display-only, and the CLI section and key-behaviors entry describe the ETA as structured end to end (status.ETA → ETASeconds → task row → API → ui.FormatETA).

Before                                         After

Spirit status.Progress                         Spirit status.Progress
  Tables[].RowsCopied/RowsTotal                  Tables[].RowsCopied/RowsTotal
  ETA{State, Duration}                           ETA{State, Duration}
        │                                              │
        ▼                                              ▼
engine.TableProgress                           engine.TableProgress
  RowsCopied, RowsTotal, Progress, ETASeconds     RowsCopied, RowsTotal, Progress, ETASeconds
  ProgressDetail = "…copyRows"  (synthesized)
        │                                              │
        ▼                                              ▼
CLI templates                                  CLI templates
  regex-parses ProgressDetail, overrides         render from the structured fields
  RowsCopied/RowsTotal/Percent

Two properties worth calling out:

• Nothing an operator sees changes. TEMPLATES.md regenerates byte-identical, and the log previews render the same heartbeat lines from ETASeconds that they previously carried in the fixture string.
• Spirit needs no change for this. The ETA was upstreamed into status.ETA earlier; this PR retires the consumer-side parser that outlived it. The one remaining string-only value in Summary (the runner-wide aggregate CopyProgress) is never read here; feat(status): expose row-copy progress as a structured field on Progress spirit#1220 adds it as a Copy field on status.Progress so that every value in Summary has a typed counterpart, and the doc here now says that a value found only in Summary is fixed upstream, not parsed.

How it moves us toward the northstar

The progress path is now structured from the engine to the terminal with no text in between, which is the shape Upstream First asks for: when Spirit adds a signal, SchemaBot picks it up as a field, and when SchemaBot needs one Spirit lacks, the fix lands in Spirit for every consumer rather than as a parser here.

Opened by Claude (Fable 5).

[Copilot]

🟡 Changes recommended

The CLI now drops and never renders progress_detail, which removes operator-facing notes still produced by the engine (e.g., direct execution markers and early Summary fallback).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Refactors Spirit progress rendering to be fully structured end-to-end (rows/percent/ETA/throttle/checksum), removing the legacy regex-based parsing of Spirit-shaped progress strings in the CLI and updating documentation to reflect the structured data flow.

Changes:

• Removed ParseSpiritProgress + regex parsing and switched CLI progress rendering to rely solely on structured fields.
• Stopped the Spirit engine wrapper from synthesizing a "X/Y Z% copyRows" ProgressDetail string.
• Updated docs/spirit_progress.md to document status.ETA / checksum progress as structured fields and to describe Summary as display-only.

File summaries

File	Description
pkg/engine/spirit/spirit.go	Stops synthesizing copy progress detail strings; keeps structured fields as source of truth.
pkg/engine/spirit/spirit_test.go	Updates tests to stop asserting on the synthesized ProgressDetail string.
pkg/engine/spirit/drain_outcome_test.go	Updates drained-outcome tests to remove expectations around dropped detail lines.
pkg/engine/engine.go	Clarifies TableProgress.ProgressDetail semantics as a non-parsed human note.
pkg/cmd/internal/templates/progress.go	Removes string-parsing branch; renders in-progress output from structured fields only.
pkg/cmd/internal/templates/progress_states_test.go	Updates CLI rendering tests to no longer rely on ProgressDetail fixtures.
pkg/cmd/internal/templates/progress_parse.go	Removes parsing/override logic and drops ProgressDetail from internal CLI types.
pkg/cmd/internal/templates/progress_parse_test.go	Adjusts parsing tests to validate structured field pass-through + status normalization.
pkg/cmd/commands/preview_log.go	Updates preview fixtures to set ETASeconds directly instead of embedding ETA in ProgressDetail.
pkg/cmd/commands/apply_log_test.go	Updates log emitter test naming and removes reliance on a Spirit detail string.
docs/spirit_progress.md	Updates documentation to describe ETA/checksum as structured and Summary as display-only.

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.