Skip to content

fix(cli): allow PDF uploads - #7476

Open
imetandy wants to merge 2 commits into
block:mainfrom
imetandy:fix/cli-pdf-upload
Open

imetandy wants to merge 2 commits into
block:mainfrom
imetandy:fix/cli-pdf-upload

Conversation

@imetandy

@imetandy imetandy commented Sep 8, 2026

Copy link
Copy Markdown

Summary

  • allow application/pdf through the CLI upload MIME gate
  • render PDFs as file attachments rather than broken inline images
  • preserve the original filename in imeta metadata
  • use the relay-aligned 100 MiB generic-file size limit for PDFs
  • add regressions for PDF upload, rendering, filename metadata, image rendering, and size selection

The relay already accepts PDFs on its generic file path; the CLI was rejecting them before sending the request.

Fixes #2963.

Closest existing work: #6364 is broader and currently blocked; this PR is the minimal PDF-only fix for a reproduced user-facing failure.

Verification

  • cargo test -p buzz-cli — 467 passed
  • cargo clippy -p buzz-cli --all-targets -- -D warnings — passed
  • cargo fmt -p buzz-cli — passed
  • git diff --check — passed

Signed-off-by: imetandy <robinson.andrewjames@gmail.com>
@imetandy
imetandy requested a review from a team as a code owner September 8, 2026 07:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T07:27:46.931979Z 477035a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is 3c7f288c60d67df78577b237e27c3dfc8831aaa1...aa70af75fc1f8689a2504c17012dca747c986352.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review aa70af75fc1f8689a2504c17012dca747c986352 to authorize a new review.
Any previous review applies only to its recorded range.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 477035af57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/buzz-cli/src/client.rs
Comment thread crates/buzz-cli/src/client.rs
Signed-off-by: imetandy <robinson.andrewjames@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

buzz upload file rejects PDFs/documents the relay accepts — agents can't attach files the desktop can

1 participant