fix(acp): keep ordinary DM replies top-level - #6540
Conversation
Co-authored-by: Sol <2b9138a3d6b57c68c891dbd09a4f2f4fee6ff7a0eb3b05a0b852a8e52581791e@buzz.block.builderlab.xyz> Signed-off-by: Sol <2b9138a3d6b57c68c891dbd09a4f2f4fee6ff7a0eb3b05a0b852a8e52581791e@buzz.block.builderlab.xyz>
Chessing234
left a comment
There was a problem hiding this comment.
this is done the right way round — the DM branch stops emitting the anchor rather than just discouraging its use, and both affected tests are renamed and rewritten to assert the new behaviour instead of being deleted. no complaints about the mechanism.
one line i'd question: "If the requested destination is ambiguous, ask before sending." in a human-agent DM that's clearly right. in an agent-to-agent DM there may be nobody to ask, and the turn ends with a question nobody answers — which looks identical to the agent silently doing nothing. is that branch reachable for agent-to-agent turns, and if so is stalling the intended outcome there, or should it default to top-level and proceed?
not blocking — the rest of the instruction is unambiguous enough that ambiguity should be rare.
Summary
Validation
cargo fmt --checkcargo test -p buzz-acp(804 unit tests + 9 lifecycle tests passed)just cireached desktoppnpm check, then failed because pnpm dependency fetches returnedTypeError: fetch failed; Rust workspace checks completed firstOriginating Buzz DM:
44111ea4-ec72-464a-905e-ce65bbb29d4a