Add cancellation and below-threshold investment notifications #626
+721
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NotifyFounderOfInvestment` handler for notifying founders of direct investments, updated synchronization logic to process and store investment notifications, and expanded `Handshakes` to support direct investments.
…lation` handler to notify founders of investment cancellations via Nostr, updated handshake synchronization logic to process cancellations, and extended `InvestmentStatus` to include `Cancelled`.
DavidGershony
force-pushed
the
invest-nostr-event
branch
from
21b8efe to
36c300a
Compare
Member
|
the checklist is a todo list? or what has been done? |
dangershony
reviewed
Jan 23, 2026
|
|
||
| namespace Angor.Sdk.Funding.Investor.Operations; | ||
|
|
||
| public static class NotifyFounderOfCancellation |
Member
There was a problem hiding this comment.
Shouldn't we have a general notification message and inside several options? looks to me like here we will have a different message type per notification
dangershony
reviewed
Jan 23, 2026
| { | ||
| switch (messageType) | ||
| { | ||
| case InvestmentMessageType.Request: |
Member
There was a problem hiding this comment.
ah sorry I see we do have messages types
dangershony
reviewed
Jan 23, 2026
| return; | ||
|
|
||
| if (userEoseActions.TryGetValue(_.Subscription, out var action)) | ||
| if (userEoseActions.Remove(_.Subscription, out var action)) |
dangershony
approved these changes
Jan 23, 2026
Member
dangershony
left a comment
dangershony
left a comment
There was a problem hiding this comment.
looks good to me, is the pr finished?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the following changes:
NotifyFounderOfCancellationhandler to notify founders of investment cancellations using Nostr. Updated handshake synchronization logic to process cancellations and extended theInvestmentStatusenum to include aCancelledstatus.NotifyFounderOfInvestmenthandler to notify founders of direct investments. Updated synchronization logic to process and store investment notifications and expanded theHandshakeslogic to support direct investments.Checklist