Feature/misc meson improvements #1992
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Whoops, i missed that this needed rebasing |
perigoso
force-pushed
the
feature/misc-meson-improvements
branch
3 times, most recently
from
8aedc0d to
73a4cb1
Compare
dragonmux
added
Enhancement
perigoso
force-pushed
the
feature/misc-meson-improvements
branch
4 times, most recently
from
64603a5 to
4645855
Compare
Previously when configuring the build for a probe manually, the default would be to enable all debug targets This could lead to user confusion as the build would fail due to lack of space for some probes, for this reason an edge case condition was added to override the defaults, the method employed does have a problems, it prevents enabling all targets explicitly for the affected probems, even if the user knows what they are doing, and increases the maintenance burden as a list of enabled targets needs to be maintained in multiple places This makes it so the default for manually configured builds (i.e. not using the pre-made cross-files) is to not enable *any* debug targets, they must be configured manually, this gives a clear warning if one would forget to do this, and removes the maintenance burden with duplicate lists
This automatically adds all targets to the libbmd dependencies removing the need to manually update this list when new targets are added
although it is tied to the debug target configuration being dependent on riscv_jtag_dtm, this option just sets a define and is better grouped with other similar configuration options
store the dependency objects themselves instead of strings massage the target declarations to remove conditional targets based on which targets are enabled
after a small rewrite the name of the target options changed slightly, meaning more targets were enabled by default than before this commit adjusts this to retain the previous behavior
Use a dictionary in place of named variables and the get variable method
perigoso
force-pushed
the
feature/misc-meson-improvements
branch
from
4645855 to
1fd83e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
This is a minor cleanup/simplification of the meson configuration around the target enabling
This should result in no behavior changes, except for a small, but very intentional one.
Right now when manually configuring the build, i.e. not using the pre-made cross-files for the probes, the default behaviour was to enable all targets by default, resulting in the need to safe-guard against special cases for certain probes to reduce user confusion.
This changes things such that by default when manually configuring the build no targets are enabled by default, a helpful error message should be displayed about it (improvement over the previous compilation error).
I think this makes sense because this is to me an "advanced user" usage and reduces the maintenance burden on the build system.
Your checklist for this pull request
Closing issues