Skip to content

Fix Autofill settings deeplink #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SaintPatrck
Copy link
Contributor

๐ŸŽŸ๏ธ Tracking

N/A

๐Ÿ“” Objective

The startSystemAutofillSettingsActivity function was incorrectly negating the result of startActivity. This commit removes the negation to correctly reflect the activity launch status.

๐Ÿ“ธ Screenshots

Coming soon!

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

The `startSystemAutofillSettingsActivity` function was incorrectly negating the result of `startActivity`. This commit removes the negation to correctly reflect the activity launch status.
Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ f2b307ba-9c0b-4f63-a242-9d2b0a56dce0

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Aug 15, 2025

Codecov Report

โœ… All modified and coverable lines are covered by tests.
โš ๏ธ Please upload report for BASE (main@5a23cea). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5704   +/-   ##
=======================================
  Coverage        ?   83.91%           
=======================================
  Files           ?      692           
  Lines           ?    52864           
  Branches        ?     7257           
=======================================
  Hits            ?    44360           
  Misses          ?     5962           
  Partials        ?     2542           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„๏ธ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant