-
Notifications
You must be signed in to change notification settings - Fork 738
[XPU] Implemented 8bit optimizers in triton #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Egor-Krivov
wants to merge
10
commits into
bitsandbytes-foundation:main
Choose a base branch
from
Egor-Krivov:egor/8bit_opt2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[XPU] Implemented 8bit optimizers in triton #1692
Egor-Krivov
wants to merge
10
commits into
bitsandbytes-foundation:main
from
Egor-Krivov:egor/8bit_opt2
+1,014
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@matthewdouglas This PR is ready for review. Interface with 8bit interface was merged #1706 |
Benchmarking on Torch is 32bit optimizer from torch, BNB is 8bit optimizer:
For small shapes difference is smaller (1024*9):
benchmark is based on optimizer tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented 8bit optimizers in triton to use of XPU devices.
Depends on interface from #1706
Tested with
BNB_TEST_DEVICE="xpu" pytest --show-capture=no -q tests/test_optim.py::test_optimizer8bit
Benchmarked essentially on the same test, getting better performance than torch optimizer.
This PR contains 3 implementations: