STEP-3 ADDED CARDS SHUFFLING FUNCTIONALITY #24
+182
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratham1002
requested changes
Aug 18, 2020
server/sockets/socket-server.js
Outdated
| for (var a=[],i=0;i<54;++i) a[i]=i; | ||
|
|
||
| function shuffle(array) { | ||
| var tmp, current, top = array.length; |
There was a problem hiding this comment.
need to use it const give an linting error in ++i and let gives an error in a =shuffle(a).Any other suggestions?
pratham1002
reviewed
Aug 18, 2020
pratham1002
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added cards shuffling function ,the server would be sending a 2-d array to all clients where playercards[i] would contain card ids which will be random number from 0 to 53 for ith player .