[bitnami/mongodb-sharded] predictable port number for metrics #34439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Fokin <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
carrodher
added
verify
Signed-off-by: Bitnami Bot <[email protected]>
Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Alexander Fokin <[email protected]>
|
@fmulero thank you, applied you suggestions |
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Aleksandr Fokin <[email protected]>
alrf
force-pushed
the
mongodb-sharded/metrics-port
branch
from
6604456 to
9d5377c
Compare
Signed-off-by: Alexander Fokin <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Alexander Fokin <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Aleksandr Fokin <[email protected]>
… into mongodb-sharded/metrics-port
Done |
fmulero
previously approved these changes
Jun 24, 2025
Signed-off-by: Bitnami Bot <[email protected]>
fmulero
approved these changes
Jun 24, 2025
nicolas-laduguie
pushed a commit
to nicolas-laduguie/bitnami-charts
that referenced
this pull request
Jul 9, 2025
…i#34439) * [bitnami/mongodb-sharded] predictable port number for metrics Signed-off-by: Aleksandr Fokin <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * Update bitnami/mongodb-sharded/templates/mongos/mongos-service.yaml Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Alexander Fokin <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * [bitnami/mongodb-sharded] predictable port number for metrics Signed-off-by: Aleksandr Fokin <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * Update bitnami/mongodb-sharded/Chart.yaml Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Alexander Fokin <[email protected]> * Update CHANGELOG.md Signed-off-by: Bitnami Bot <[email protected]> * [bitnami/mongodb-sharded] predictable port number for metrics Signed-off-by: Aleksandr Fokin <[email protected]> --------- Signed-off-by: Aleksandr Fokin <[email protected]> Signed-off-by: Bitnami Bot <[email protected]> Signed-off-by: Alexander Fokin <[email protected]> Co-authored-by: Bitnami Bot <[email protected]> Co-authored-by: Fran Mulero <[email protected]> Signed-off-by: Nicolas Laduguie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Make the metrics port predictable (in case of service type
NodeType) - it will be.Values.service.nodePorts.mongodb + 1, e.g. 30817 is a mongodb port, then the metrics port will be 30818.Benefits
Make the metrics port predictable and not random in case of NodeType.
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm