feat(graphics-overhaul): support 'old feedbacks' #3482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See a full explanation of the plan and reasoning in #3293 (comment)
This is my pitch on how to handle 'old feedbacks' (primarily advanced feedbacks) that don't fit into the new element based flow.
I see this as a medium term solution, until we can drop support for versions of the module-api that support advanced feedbacks.
The hope here is to make it so that existing configs could be auto-converted across without affecting how buttons are drawn (for the simple square button case). This theory is not implemented, and needs testing to verify if it will work well enough.
TODO: