peers: move to maxAge instead of timeslotting #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertkowalski dht out with the maxAge option, we should bump the semver to ^7.9.0 |
prdn
reviewed
Jan 11, 2018
README.md
Outdated
| --dht_maxValues DHT max values [number] | ||
| --bn, --bootstrap Bootstrap nodes [string] [required] | ||
| --aph, --api_port HTTP api port [number] [required] | ||
| --dht_peer_maxAge, --dts Max age for peers in DHT [number] |
There was a problem hiding this comment.
@robertkowalski we should probably use --dpma or dpa as alias
robertkowalski
force-pushed
the
maxage
branch
from
561acde to
d39e6d6
Compare
|
@mafintosh bumped! @prdn changed! |
mafintosh
reviewed
Jan 11, 2018
package.json
Outdated
| "dependencies": { | ||
| "async": "^2.6.0", | ||
| "bittorrent-dht": "^7.8.2", | ||
| "bittorrent-dht": "7.9.0", |
There was a problem hiding this comment.
we should still have the ^ here
robertkowalski
commented
Jan 11, 2018
lib/Grape.js
Outdated
| const kcnt = this.cbq0.cnt(ih) | ||
| if (kcnt > 1) return | ||
|
|
||
| this._mem.remove(ih) |
There was a problem hiding this comment.
@mafintosh hmm
robertkowalski
changed the title
prdn
reviewed
Jan 11, 2018
| dht_nodeLiveness: 5 * 60 * 1000, // 5 min | ||
| api_port: null, | ||
| timeslot: 10000 | ||
| dht_peer_maxAge: 10000 |
There was a problem hiding this comment.
@robertkowalski I think this should be 60000 as default. 10000 is a bit too low.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased and incorporated feedback from #45
todo: