feat(qt): add /clearhistory command #214
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-jr
reviewed
Nov 4, 2025
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
ddf5fe4 to
d272991
Compare
luke-jr
reviewed
Nov 4, 2025
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
d272991 to
a516809
Compare
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
a516809 to
7cb0262
Compare
luke-jr
requested changes
Nov 7, 2025
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
7cb0262 to
918f4ec
Compare
luke-jr
requested changes
Nov 8, 2025
luke-jr
reviewed
Nov 8, 2025
luke-jr
reviewed
Nov 8, 2025
luke-jr
reviewed
Nov 8, 2025
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
918f4ec to
1498a7b
Compare
luke-jr
requested changes
Nov 10, 2025
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
2 times, most recently
from
2eb19df to
de081d7
Compare
bigshiny90
suggested changes
Dec 4, 2025
bigshiny90
left a comment
bigshiny90
left a comment
There was a problem hiding this comment.
doing a quick code review and testing while running. not a lot to add regarding code, as you all have done much work there.
outstanding question for me is: this slash command has no discoverability - neither in help or help-console. Should it not be documented there otherwise how would a user know about it? (I may be missing something obvious?)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
kwsantiago
force-pushed
the
kwsantiago/204-clearhistory
branch
from
de081d7 to
497efdf
Compare
Author
|
@bigshiny90 thank you for the feedback. Addressed in 497efdf |
bigshiny90
approved these changes
Dec 4, 2025
bigshiny90
left a comment
bigshiny90
left a comment
There was a problem hiding this comment.
That's great. Added documentation to help-console and autocomplete for /clear-history.
Tested on linux.
looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUI/Console: Add /clearhistory command
Closes #204
Implementation
/clearhistoryhistory.clear()and overwrites saved history again