BIP93: Restrict master seed lengths and Revise codex32 string length specifications #2077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codex32: String length limits now cover HRP characters, tighter master seed bit length limits, updated master seed encoding/decoding processes.
Rationale
Helper PR for #2040: prepares the text for general HRP lengths by defining limits based on string length not data part length and deprecating "ms" seed lengths that violate the new codex32 length rule.
Why
Restricting seeds to 32-bit multiples makes valid secret seed lengths differ by at least 6-7 characters reducing ambiguity to two valid lengths for insert/delete-correcting error correcting wallets. Restricting to 64-bit multiples has one valid length within correctable distance but @roconnor-blockstream wants 160-bit seeds.
Key changes (concise) c286c2c
My Summary of other Changes:
<ref>notes for the less obvious changes./refso Footnotes now appear at the end of Rationale (they're invisible in master)Backward-compatibility and migration
Test Vectors
I have a working reference implementation that can validate according to this text's spec as well as #2040's plan so I will be able to generate these and add them after reviewers agree about the text changes. After a round or so of reviews I'll mark this draft and add Vectors and my passing reference implementation.
The Master seed format deterministic encoding recommendations both need vectors. As do now invalidated "ms" lengths that are not multiples of 4 bytes.
Proposed reviewer checklist