Skip to content

Try to fix broken tests #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hostep wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Try to fix broken tests #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8e9bbf
Adds '--no-security-blocking' flag to 'composer update' commands whic…
hostep Jan 28, 2026
06ba107
Let's ignore some phpstan problems which aren't important
hostep Jan 28, 2026
84fdefb
Drop Magento 2.4.4/2.4.5 and introduce 2.4.7/2.4.8, also use latest s…
hostep Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
---
name: ci
on:
pull_request:
Expand All @@ -11,12 +12,12 @@ jobs:
strategy:
matrix:
operating-system: ['ubuntu-latest']
php-versions: ['8.1']
magento: ['2.4.4', '2.4.5']
coveralls: [ false ]
php-versions: ['8.2']
magento: ['2.4.6', '2.4.7']
coveralls: [false]
include:
- php-versions: '8.1'
magento: '2.4.6'
- php-versions: '8.2'
magento: '2.4.8'
operating-system: 'ubuntu-latest'
coveralls: true
steps:
Expand All @@ -34,17 +35,17 @@ jobs:
- name: Install Composer dependencies
run: composer install

- name: Install Magento 2.4.4
if: matrix.magento == '2.4.4'
run: composer update --with-dependencies magento/framework:103.0.4 laminas/laminas-code:4.5.1 symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.5
if: matrix.magento == '2.4.5'
run: composer update --with-dependencies magento/framework:103.0.5 laminas/laminas-code:4.5.2 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.6
if: matrix.magento == '2.4.6'
run: composer update --with-dependencies magento/framework:103.0.6 laminas/laminas-code:4.10.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker
run: composer update --with-dependencies magento/framework:103.0.6-p13 laminas/laminas-code:4.17.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.7
if: matrix.magento == '2.4.7'
run: composer update --with-dependencies magento/framework:103.0.7-p8 laminas/laminas-code:4.17.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Install Magento 2.4.8
if: matrix.magento == '2.4.8'
run: composer update --with-dependencies magento/framework:103.0.8-p3 laminas/laminas-code:4.17.0 roave/security-advisories symfony/yaml symfony/console madewithlove/license-checker

- name: Composer license check
run: composer check-license
Expand Down
12 changes: 12 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,15 @@ parameters:
-
message: '~PHPDoc tag @var assumes the expression with type~'
path: tests/bitExpert/PHPStan/Magento/Type/TestFrameworkObjectManagerDynamicReturnTypeExtensionUnitTest.php
-
message: '~Parameter \#1 \$key of method PHPStan\\Cache\\Cache\:\:(?:load|save)\(\) expects non\-empty\-string, string given\.~'
path: src/bitExpert/PHPStan/Magento/Autoload/ExtensionAutoloader.php
-
message: '~Parameter \#1 \$key of method PHPStan\\Cache\\Cache\:\:(?:load|save)\(\) expects non\-empty\-string, string given\.~'
path: src/bitExpert/PHPStan/Magento/Autoload/ExtensionInterfaceAutoloader.php
-
message: '~Parameter \#1 \$key of method PHPStan\\Cache\\Cache\:\:(?:load|save)\(\) expects non\-empty\-string, string given\.~'
path: src/bitExpert/PHPStan/Magento/Autoload/FactoryAutoloader.php
-
message: '~Parameter \#1 \$key of method PHPStan\\Cache\\Cache\:\:(?:load|save)\(\) expects non\-empty\-string, string given\.~'
path: src/bitExpert/PHPStan/Magento/Autoload/ProxyAutoloader.php
Loading