Closed
Conversation
Member
|
thanks for the contribution! please fix the ci. the tests are failing now |
Contributor
Author
fixed @amiremohamadi |
Member
Member
|
also consider that we're using the free plan, so it shouldn't reach the free plan limits. maybe d1 is a better choice? it requires an R&D |
Contributor
Author
We’ve already fixed the issue, so hitting the free plan limits shouldn’t be a problem. D1 could be a better pick, but as you said, it’ll need some R&D. |
Member
|
closed as stale. feel free to open a new PR in case u wanted to continue working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixed #26