feat(js_analyze): implement useRegexpExec

[Netail]

Summary

Port Typescript Eslint's prefer-regexp-exec

Closes #7797

Test Plan

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: e102487

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codspeed-hq]

CodSpeed Performance Report

Merging #8034 will not alter performance

_{Comparing Netail:feat/use-regexp-exec (e102487) with main (dc1217c)¹}

Summary

✅ 53 untouched
⏩ 90 skipped²

Footnotes

1. No successful run was found on main (c09e45c) during the generation of this report, so dc1217c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 90 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Netail]

Not sure how how to resolve the value of a reference.

Could also use the type of the expression, then check the flags within the regex type? Not sure if that's valid?

[dyc3]

What does the source rule do? https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts

[Netail]

They seem to call an Eslint API to get the value of a given node if it can be decided statically. (not through types) But not sure if biome provides such API?

https://eslint-community.github.io/eslint-utils/api/ast-utils.html#getstaticvalue

[dyc3]

We have the semantic model and the control flow graph, but iirc typed rules shouldn't be using those because they use the module graph. @arendjr, I'd appreciate your input here, you have more context on the type system and the module graph than I do.

[arendjr]

Typed rules can also use the semantic model and the control flow graph, but the semantic model is largely redundant with functionality that is already provided by the typed service, which provides similar things, but with a higher level of abstraction that includes types and cross-module inference.

So far the abstract way of looking at it :)

Unfortunately we don't really have an API yet that can determine static values (AFAIK), but the typed service actually does try to determine static values when it can determine them. Simple example:

const foo = 1;
foo;

The type system will be able to determine that the reference to foo on the second line resolves to the concrete value 1, because in TypeScript concrete values can be used as types as well and we try to infer as specific as we can. So yes, I think using the type system is probably the way to go here, but some more work will be necessary. I don't think we have any specific detection for RegExp yet, and I haven't looked yet into what flags need to be checked, but that might require some custom logic too?

If you like, I might be interested to look into this next week.

[Netail]

That would be awesome. For now I only need to check on the global flag. But some API to the regexp type could be to check if it has any given flag could be nice