fix rounding errors in Hill functions#183
fix rounding errors in Hill functions#183murrayrm wants to merge 1 commit intobiocircuits:masterfrom
Conversation
|
The build that is failing seems to be unrelated to this PR. It looks like there is not an Arm-based wheel for libsbml under Python 3.8. I think this is due to GitHub switching to Arm-based MacOS workflows? Will look into it later. |
|
Yeah, was just looking into this as well. They just switched to apple silicon for macos it seems. Is it okay to just drop macos python 3.8 (perhaps drop python 3.8 entirely)? Alternatively, it looks like More info here |
|
Python 3.8 (and 3.9) is past end-of-life, so seems fine to drop it and just leave 3.11 and 3.12. We should probably eventually do 3.11 and 3.13 or 3.14 (most recent releases). I know there were some issues in BioCRNpyler with 3.13 and Numpy 2; not s ure about BioSCRAPE. |
This is a small change in the way propensity functions are handled to avoid errors where
X ** nfails ifXis a small negative number (like -1e-30). This occurs fairly frequently in BioSCRAPE simulations when a variable is initialized to zero (and apparently numerical errors cause it to go negative).