Conversation
Exporting everything does not really make sense. On large instances it is not possible and on small instances "everything" can be selected with "only".
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the export API so that exporting “everything” is no longer allowed; callers must provide either an inclusion (only) or exclusion (except) filter, with request validation centralized in a new FormRequest.
Changes:
- Added
ShowExportFormRequest to parse/validateonly/exceptquery filters. - Updated the shared export controller to use the FormRequest and apply filtered
whereIn/whereNotInqueries. - Updated export controller tests to reflect the new validation behavior and cover invalid filter inputs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/php/Http/Controllers/Api/Export/VolumeExportControllerTest.php | Adjusts tests to require only/except and adds invalid-filter assertions. |
| tests/php/Http/Controllers/Api/Export/UserExportControllerTest.php | Adjusts tests to require only/except, changes expected exported set, adds invalid-filter assertions. |
| tests/php/Http/Controllers/Api/Export/LabelTreeExportControllerTest.php | Adjusts tests to require only/except and adds invalid-filter assertions. |
| app/Http/Requests/ShowExport.php | New FormRequest for parsing/validating export filters. |
| app/Http/Controllers/Api/Export/VolumeExportController.php | Updates API docs to state a filter is required. |
| app/Http/Controllers/Api/Export/UserExportController.php | Updates API docs to state a filter is required. |
| app/Http/Controllers/Api/Export/LabelTreeExportController.php | Updates API docs to state a filter is required. |
| app/Http/Controllers/Api/Export/Controller.php | Switches to ShowExport and applies parsed filter arrays to the query. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exporting everything does not really make sense. On large instances it is not possible and on small instances "everything" can be selected with "only".