Skip to content

Pause/resume for lawnmower#1491

Open
yannik131 wants to merge 22 commits into
masterfrom
547-pause-resume-for-lawnmower
Open

Pause/resume for lawnmower#1491
yannik131 wants to merge 22 commits into
masterfrom
547-pause-resume-for-lawnmower

Conversation

@yannik131

Copy link
Copy Markdown
Contributor

Closes #547

@yannik131

Copy link
Copy Markdown
Contributor Author

Architectural sketch of what I implemented:

  • introduce a PlayPause component for the two buttons
  • annotatorContainer defines
    • currentLawnmowerState, which is passed as a prop to annotationModesTab -> playPause
    • lawnmowerSaveState (load, save, discard), passed as a prop to annotationCanvas/lawnmower.vue, watcher for changes
  • data flow is then:
    1. user requests change in playPause.vue (emit lawnmowerStateChangeRequested)
    2. annotationModesTab.vue re-emits
    3. annotatorContainer.vue changes the state if possible and updates both props
    4. change is reflected in playPause via the currentLawnmowerState prop, annotationModesTab.vue updates the mode
    5. annotationCanvas/lawnmower.vue loads/saves/discards the state (current image, current section) from local storage tied to volume ID
  • then do the same for label review mode

@yannik131

yannik131 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

@mzur It's working now, but the architecture is not really consistent (mixin/options API for lawnmower, composable for volare). I managed to move the volare-logic from the AnnotatorContainer into the composable and would like to do the same for the lawnmower, but would first like to get some feedback from you regarding the overall structure. I'll mark it ready for review anyways.

Edit: Oh, and also I've run out of AI credits, so I can't use copilot for reviews right now. Since the switch to the new credits-based pricing model a single larger AI code review uses up about 25% of my $2.00 worth of free credits.

Edit 2: I also noticed a bug in the original behaviour that is still present: Focus annotation in volare, filter annotations that keeps the focussed annotation on the screen, remove filter -> wrong annotation is focussed. I will resume development once I get your feedback regarding the structure, though.

@yannik131 yannik131 marked this pull request as ready for review June 20, 2026 12:43
@yannik131 yannik131 requested a review from mzur June 20, 2026 12:44
@mzur mzur removed their request for review June 25, 2026 12:12
@mzur

mzur commented Jun 25, 2026

Copy link
Copy Markdown
Member

I'll skip the review until we finished the discussion in the issue. Let me know if I should request an AI review for you here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pause/Resume for Lawnmower and Volume Label Review Modes

2 participants