Skip to content

Console error volare - #1465

Merged
mzur merged 1 commit into
masterfrom
1121-console-error-volare
May 21, 2026
Merged

mzur merged 1 commit into
masterfrom
1121-console-error-volare

Conversation

@yannik131

Copy link
Copy Markdown
Contributor

Closes #1121

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a console error triggered when switching from the measurement tool to the volume label review tool and navigating images (issue #1121). It prevents the measurement tooltip update logic from running when there is no active measurement feature.

Changes:

  • Guarded the image watcher in the measure interaction mixin to only update the measure tooltip when measureFeature exists.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@yannik131

Copy link
Copy Markdown
Contributor Author

@mzur The issue was this:

  • When a measurement is started with left mouse click, the total length is displayed in a tooltip (the measureFeature)
  • When jumping to the next image (regardless if in volare mode or not), to preserve the tooltip, updateMeasureFeature with the measure feature is called
  • If no measure feature exists because measuring hasn't started yet, this will cause an error trying to access a property of undefined
  • To preserve current behaviour, I just added a check if the measure feature is actually present

@yannik131
yannik131 marked this pull request as ready for review May 20, 2026 13:41
@yannik131
yannik131 requested a review from mzur May 20, 2026 13:41

@mzur mzur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@mzur
mzur merged commit 277ff93 into master May 21, 2026
3 checks passed
@mzur
mzur deleted the 1121-console-error-volare branch May 21, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Measurement tool throws console error after using volume label review tool

3 participants