Removing unconditional setUnfixed() call #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaDiallo
changed the title
|
@IlyaDiallo I am having problems with the scrolling but this change did not fix that for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setUnfixedcall in thescrolltrigger was introduced in this commit.At the time it was probably required for some cases, but in the current code
checkScrollcallssetUnfixedinternally in all the cases where it's required. The problem with the extra unconditionalsetUnfixedcall I'm removing is that it's messing with thepositionvariable when the status is already "unfixed" and the consequence is the risk of spurious scrolling of the display, for example when a fixed div is redrawn (similar to #230).