refactor: remove SIP.js-associated code#835
Open
prlanzarin wants to merge 2 commits into
Open
Conversation
The SIP.js audio bridge is removed from BigBlueButton in favor of the mediasoup (fullaudio) and LiveKit bridges, so the installer no longer configures it. Drop the sip.nginx proxy_pass/IP rewrites as the bbb-html5 package no longer ships sip.nginx, as well as the the sipjsHackViaWs client override. Keep the FreeSWITCH ws-binding (:5066) and freeswitch.sip_ip setup as bbb-webrtc-sfu connects to FreeSWITCH over ws://IP:5066. Ref. bigbluebutton/bigbluebutton#20852
The FreeSWITCH wss-binding (:7443) secure SIP-over-WebSocket listener was reached only by the removed browser SIP.js bridge via the nginx /ws proxy. bbb-webrtc-sfu connects over :5066 *only&, so bbb-install no longer needs to set wss-binding. Ref. bigbluebutton/bigbluebutton#20852
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bigbluebutton/bigbluebutton#25237, bigbluebutton/bigbluebutton#20852.
mediasoup (fullaudio) and LiveKit bridges, so the installer no longer
configures it. Drop the sip.nginx proxy_pass/IP rewrites as the
bbb-html5 package no longer ships sip.nginx, as well as the the
sipjsHackViaWs client override.
was reached only by the removed browser SIP.js bridge via the nginx
/ws proxy. bbb-webrtc-sfu connects over :5066 *only&, so bbb-install
no longer needs to set wss-binding.