fix vignette figure paths and sv_importance variable name#84
Merged
Conversation
added 3 commits
April 20, 2026 22:36
Change fig.path from man/figures/ to figures/ in fastshap.Rmd.orig so figures land in vignettes/figures/ (relative to vignettes/) and resolve correctly when rmarkdown renders the vignette. Update knit comment to reflect running from inside vignettes/. Copy existing PNGs to vignettes/figures/ and update all src= paths in the pre-rendered .Rmd. Also fix sv_importance(shv) -> sv_importance(shv.global) in both files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fig.pathinfastshap.Rmd.origwasman/figures/(relative to package root when knitting), butrmarkdown::render()runs fromvignettes/, so images couldn't be found. Changed tofigures/and updated the knit workflow to run from insidevignettes/.vignettes/figures/with all 7 pre-rendered PNGs copied fromman/figures/.src=paths in the pre-renderedfastshap.Rmdto match.sv_importance(shv)→sv_importance(shv.global)in both.origand the rendered.Rmd(wrong variable from local explanations section was referenced in the global explanations section).Test plan
rmarkdown::render("vignettes/fastshap.Rmd")— open output HTML and confirm all 7 plots appearpkgdown::build_site()— confirm no new errors; article page shows all plots