Move data of tasktracer to the right place in the JSON object.#68
Open
ThinkerYzu wants to merge 2 commits intobgirard:masterfrom
Open
Move data of tasktracer to the right place in the JSON object.#68ThinkerYzu wants to merge 2 commits intobgirard:masterfrom
ThinkerYzu wants to merge 2 commits intobgirard:masterfrom
Conversation
| case "profileJSONWithSymbolicationTable,1": | ||
| symbolicationTable = rawProfile.symbolicationTable; | ||
| parseProfileJSON(rawProfile.profileJSON); | ||
| if (rawProfile.profileJSON.tasktracer) { |
Owner
There was a problem hiding this comment.
Looks like we're mixing rawProfile.profileJSON.tasktracer vs rawProfile.tasktracer here.
We don't have existing saved profiles we need to support so we don't need to move the tasktracer sub-object. We should pick where we want it to be live and always look for it there.
Owner
|
I'll merge with once we stop moving tasktracer but rather make sure everything is looking for it at the right place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data of tasktracer is placed in profileJSON of the JSON object from Gecko Profiler, but Cleopatra expects to see it at the root of the JSON object. This change move the data to the place where Cleopatra likes to see.