fix: add missing png feature to bevy_feathers feature#24727
Merged
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jun 23, 2026
PPakalns
reviewed
Jun 24, 2026
| ] | ||
| bevy_ui_render = ["dep:bevy_ui_render", "bevy_sprite_render", "bevy_ui"] | ||
| # Feathers ships its built-in icons as PNGs, so enable the PNG feature | ||
| bevy_feathers = ["dep:bevy_feathers", "png"] |
Contributor
There was a problem hiding this comment.
Sorry that I couldn't review this in time in github.
Shouldn't we place this requirement in bevy_feathers Cargo.toml as bevy_image = { workspace = true, features = ["png"] } ?
If library authors are developing debug UI using bevy_feathers with only required dependencies, this will not include bevy_internals crate and the png feature request will not be applied?
Contributor
Author
There was a problem hiding this comment.
I'm really no expert in this kinda stuff, so i'll defer to anyone who knows better, thanks for the input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
If
bevy_feathersis used without default features, then the built-in feathers icons arn't displayed with no warnings.Solution
Add
pngfeature flag tobevy_featherssince it has all it's widget icons as pngs.An alternate solution would be to add a warning instead somehow.
Testing
Add a simple scene with
FeathersDisclosureToggle(or any other icon using widget) and test it with no default features (but still necessary render features):Pre-fix there will be nothing dispalyed but it will work fine post-fix.
(Example command for linux)
Fixes #24682