-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Prevent AnimationGraph
from serializing AssetId
s.
#19615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andriyDev
wants to merge
10
commits into
bevyengine:main
Choose a base branch
from
andriyDev:no-asset-id-animation-clip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d36b927
to
a36ba69
Compare
Fixed a migration issue with #19631 so this is ready to review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Animation
Make things move and change over time
A-Assets
Load files from disk to use for things like images, models, and sounds
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
M-Needs-Migration-Guide
A breaking change to Bevy's public API that needs to be noted in a migration guide
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
AnimationGraph
can serialize rawAssetId
s. However for normal handles, this is a runtime ID. This means it is unlikely that theAssetId
will correspond to the same asset after deserializing - effectively breaking the graph.Solution
AssetId
to be serialized byAnimationGraph
. Serializing a handle with no path is now an error.MigrationSerializedAnimationClip
. This is an untagged enum for serde, meaning that it will take the first variant that deserializes. So it will first try the "modern" version, then it will fallback to the legacy version.Note: one limitation here is that this removes the ability to serialize and deserialize UUIDs. In theory, someone could be using this to have a "default" animation. If someone inserts an empty
AnimationClip
into theHandle::default()
, this might produce a T-pose. It might also do nothing though. Unclear! I think this is worth the risk for simplicity as it seems unlikely that people are sticking UUIDs in here (or that you want a default animation in any AnimationGraph).Testing
cargo r --example animation_graph -- --save
on main, then rancargo r --example animation_graph
on this PR. The PR was able to load the old data (after Bump ron version to 0.10. #19631).