Preserve extra data in RelationshipTarget with replace_related(_with_difference)
#19588
+84
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
variable names and comments
3 tasks
alice-i-cecile
approved these changes
Jun 13, 2025
urben1680
commented
Jun 13, 2025
urben1680
commented
Jun 13, 2025
gwafotapa
suggested changes
Jun 14, 2025
| .insert_with_relationship_hook_mode(R::from(this), RelationshipHookMode::Skip); | ||
| } | ||
| }); | ||
|
|
||
| if !entities_to_relate.is_empty() { | ||
| if let Some(mut target) = self.get_mut::<R::RelationshipTarget>() { |
There was a problem hiding this comment.
Given the if at line 244, this if let else always branches on if let.
| .insert_with_relationship_hook_mode(R::from(this), RelationshipHookMode::Skip); | ||
| } | ||
| }); | ||
|
|
||
| if !entities_to_relate.is_empty() { |
There was a problem hiding this comment.
I don't think this test is necessary.
alice-i-cecile
added
S-Waiting-on-Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The methods and commands
replace_relatedandreplace_related_with_differencemay cause data stored at theRelationshipTargetbe lost when all original children are removed before new children are added.Part of #19589
Solution
Fix the issue, either by removing the old children after adding the new ones and not before (
replace_related_with_difference) or by taking the wholeRelationshipTargetto modify it, not only the inner collection (replace_related).Testing
I added a new test asserting the data is kept. I also added a general test of these methods as they had none previously.