Skip to content

Conversation

@superdump
Copy link
Contributor

Objective

Solution

  • Schedule sweep_old_entities in QueueSweep like BinnedRenderPhasePlugin does, but for 2D where that plugin is not used.

Testing

Tested with the modified shader_defs example in #17885 .

Copy link
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@IceSentry IceSentry added A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 17, 2025
@pcwalton
Copy link
Contributor

Sorry about that, thanks for the catch!

@superdump superdump added this pull request to the merge queue Feb 17, 2025
@superdump
Copy link
Contributor Author

Sorry about that, thanks for the catch!

Easily done. No worries.

Merged via the queue into bevyengine:main with commit 8e783d3 Feb 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2d specialized material shader defs aren't updated

4 participants