Skip to content

[codex] Fix imported generic follow-ups and roadmap rename#202

Merged
berkeleynerd merged 1 commit intoberkeleynerd:mainfrom
agentc1:codex/pr1111c-generic-followup
Apr 4, 2026
Merged

[codex] Fix imported generic follow-ups and roadmap rename#202
berkeleynerd merged 1 commit intoberkeleynerd:mainfrom
agentc1:codex/pr1111c-generic-followup

Conversation

@agentc1
Copy link
Copy Markdown
Collaborator

@agentc1 agentc1 commented Apr 4, 2026

Summary

  • fix the two PR201 review findings that landed after merge: stable imported-generic specialization identity and imported generic template short-name aliases during specialization
  • add a build/proof regression covering imported helper aliasing plus same-tail imported generic collisions
  • carry the local roadmap rename/update from docs/PR11.x-series-proposed.md to docs/roadmap.md, plus the reference update in docs/post_pr10_scope.md

Validation

  • cd compiler_impl && alr build
  • python3 scripts/safe_cli.py run tests/build/pr1111c_imported_alias_and_collision_build.safe
  • python3 scripts/safe_cli.py prove tests/build/pr1111c_imported_alias_and_collision_build.safe
  • python3 scripts/run_tests.py -> 773 passed, 1 skipped, 0 failed
  • python3 scripts/run_samples.py -> 19 passed, 0 failed
  • python3 scripts/run_proofs.py -> 190 proved, 0 failed

Notes

  • this is a follow-up to merged PR201; it resolves the two post-merge generic comments that missed that merge window

@agentc1 agentc1 requested a review from berkeleynerd April 4, 2026 15:44
@berkeleynerd berkeleynerd marked this pull request as ready for review April 4, 2026 15:50
Copilot AI review requested due to automatic review settings April 4, 2026 15:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to PR201 that tightens imported-generic specialization identity and improves imported generic short-name alias handling during specialization, with a new regression fixture to cover imported helper aliasing and same-tail imported generic collisions. It also carries a documentation rename/update by moving references from docs/PR11.x-series-proposed.md to docs/roadmap.md.

Changes:

  • Fix generic specialization key/name stability by deriving specialization identity from the canonical template name (not the call-site name/alias), and extend imported-package aliasing to include generic templates.
  • Add a build regression exercising imported generic helper aliasing plus same-tail imported generic collisions; wire it into the Python build/run test harness and PR11.11c fixture inventory.
  • Update roadmap and post-PR10 scope docs to reflect the roadmap rename and expanded PR11/PR12 planning content.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/build/pr1111c_provider_collision_right.safe Adds a provider package exposing a generic marker used to validate same-tail imported generic collision behavior.
tests/build/pr1111c_provider_collision_left.safe Adds the counterpart provider package for the collision test pair.
tests/build/pr1111c_provider_alias.safe Adds a provider package where an imported generic calls another generic helper unqualified, exercising aliasing during specialization.
tests/build/pr1111c_imported_alias_and_collision_build.safe New build fixture that imports the providers and validates correct runtime output across aliasing + collisions.
scripts/run_tests.py Registers the new build fixture in the build/run regression suite with expected output.
scripts/_lib/proof_inventory.py Adds the new PR11.11c checkpoint fixtures to the centralized fixture inventory.
docs/roadmap.md Extends/updates the roadmap content (PR11.13–PR11.21 and PR12.7–PR12.14) and updates dependency chain entries.
docs/post_pr10_scope.md Updates a reference from the old roadmap doc name to docs/roadmap.md.
compiler_impl/src/safe_frontend-check_resolve.adb Adjusts imported alias handling to include generic templates and makes generic specialization keys/names stable across imported alias forms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@berkeleynerd berkeleynerd merged commit 27fce2a into berkeleynerd:main Apr 4, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants