[codex] Fix imported generic follow-ups and roadmap rename#202
Merged
berkeleynerd merged 1 commit intoberkeleynerd:mainfrom Apr 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to PR201 that tightens imported-generic specialization identity and improves imported generic short-name alias handling during specialization, with a new regression fixture to cover imported helper aliasing and same-tail imported generic collisions. It also carries a documentation rename/update by moving references from docs/PR11.x-series-proposed.md to docs/roadmap.md.
Changes:
- Fix generic specialization key/name stability by deriving specialization identity from the canonical template name (not the call-site name/alias), and extend imported-package aliasing to include generic templates.
- Add a build regression exercising imported generic helper aliasing plus same-tail imported generic collisions; wire it into the Python build/run test harness and PR11.11c fixture inventory.
- Update roadmap and post-PR10 scope docs to reflect the roadmap rename and expanded PR11/PR12 planning content.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/build/pr1111c_provider_collision_right.safe | Adds a provider package exposing a generic marker used to validate same-tail imported generic collision behavior. |
| tests/build/pr1111c_provider_collision_left.safe | Adds the counterpart provider package for the collision test pair. |
| tests/build/pr1111c_provider_alias.safe | Adds a provider package where an imported generic calls another generic helper unqualified, exercising aliasing during specialization. |
| tests/build/pr1111c_imported_alias_and_collision_build.safe | New build fixture that imports the providers and validates correct runtime output across aliasing + collisions. |
| scripts/run_tests.py | Registers the new build fixture in the build/run regression suite with expected output. |
| scripts/_lib/proof_inventory.py | Adds the new PR11.11c checkpoint fixtures to the centralized fixture inventory. |
| docs/roadmap.md | Extends/updates the roadmap content (PR11.13–PR11.21 and PR12.7–PR12.14) and updates dependency chain entries. |
| docs/post_pr10_scope.md | Updates a reference from the old roadmap doc name to docs/roadmap.md. |
| compiler_impl/src/safe_frontend-check_resolve.adb | Adjusts imported alias handling to include generic templates and makes generic specialization keys/names stable across imported alias forms. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/PR11.x-series-proposed.mdtodocs/roadmap.md, plus the reference update indocs/post_pr10_scope.mdValidation
cd compiler_impl && alr buildpython3 scripts/safe_cli.py run tests/build/pr1111c_imported_alias_and_collision_build.safepython3 scripts/safe_cli.py prove tests/build/pr1111c_imported_alias_and_collision_build.safepython3 scripts/run_tests.py->773 passed, 1 skipped, 0 failedpython3 scripts/run_samples.py->19 passed, 0 failedpython3 scripts/run_proofs.py->190 proved, 0 failedNotes